NFR Test Results for NGF version edge #2357
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
lucacome
reviewed
Aug 8, 2024
| Duration [total, attack, wait] 30.001s, 30s, 795.267µs | ||
| Latencies [min, mean, 50, 90, 95, 99, max] 566.893µs, 746.284µs, 731.685µs, 821.144µs, 856.146µs, 949.534µs, 18.228ms | ||
| Bytes In [total, mean] 5040000, 168.00 | ||
| Requests [total, rate, throughput] 29999, 1000.00, 999.97 |
There was a problem hiding this comment.
Always a chance for the traffic starting a few milliseconds after intended, which I guess could lead to a missed request.
All 200s which is ultimately what we want.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2357 +/- ##
=======================================
Coverage 88.88% 88.88%
=======================================
Files 100 100
Lines 7509 7509
Branches 50 50
=======================================
Hits 6674 6674
Misses 780 780
Partials 55 55 ☔ View full report in Codecov by Sentry. |
|
Do we want to wait until #2313 is in and then we can do another full run? |
|
should we just merge it so we have a base for zero downtime scale? |
|
@lucacome I say we wait and get a base for both new tests, then when the pipeline runs on the 15th we'll get another update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update with NFR test results for NGF version edge ["oss","plus"]